Skip to content

Fix #840 #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2015
Merged

Fix #840 #849

merged 2 commits into from
Oct 23, 2015

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 22, 2015

Problem was that interceptTypeTestCasts was run at wrong phase.
It saw after erasure a type of the form x.Array$$T. Before
erasure that type is simply an alias of another type, but after
erasure, Arraya$$T is defined to be a type alias of a Wildcard type.
Review by @DarkDimius

@odersky
Fix scala#840
82afe5f 
Problem was that interceptTypeTestCasts was run at wrong phase.
It saw after erasura a type of the form `x.Array$$T`. Before
erasure that type is simply an alias of another type, but after
erasure, Arraya$$T is defined to be a type alias of a Wildcard type.
@odersky
Don't drop impure expressions when eliding isInstanceOf tests.
f786ce5
@DarkDimius
Copy link
Contributor

LGTM

DarkDimius added a commit that referenced this pull request Oct 23, 2015
@DarkDimius
Merge pull request #849 from dotty-staging/fix-#840
50fe6eb 
Fix #840
@DarkDimius DarkDimius merged commit 50fe6eb into scala:master Oct 23, 2015
@allanrenucci allanrenucci deleted the fix-#840 branch December 14, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @DarkDimius @dottybot